-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add testing framework and non-geometric parameterisation methods #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @BradyPlanden, this is a great start. i've made a bunch of suggestions, but at this early stage there is no need to fix them all before you merge, just something to keep in mind as you develop.
tests/unit/test_parameterisation.py
Outdated
class TestParameterisation: | ||
def test_rmse(self): | ||
# Form observations | ||
Measurements = pd.read_csv("examples/Chen_example.csv", comment='#').to_numpy() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using data files can be annoying if you try to run the tests from a different directory. Could we just generate some simulation data on the fly instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair shout, this should be pretty easy to solve via importing pybamm and grabbing sample data from modified parameter simulation object.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
try not to assume you are using pybamm too widely. simulating from a model will be a pretty common thing to do, so it might be useful to have the funcionality in the model class (or if it doesn't fit there a separate Simulation or Solver class)
…conditions for rmse/nlopt
…m for spm+basemodel, parameterisation.py tidy
This PR adds the following:
Closes #21